[MINOR] Set engine when creating meta write config #7575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xccui
changed the title
codope
reviewed
Dec 28, 2022
|
|
||
| // Create the write config for the metadata table by borrowing options from the main write config. | ||
| HoodieWriteConfig.Builder builder = HoodieWriteConfig.newBuilder() | ||
| .withEngineType(writeConfig.getEngineType()) |
Member
There was a problem hiding this comment.
Thanks for the change! So, this warning is only shown for metadata table?
Member
Author
There was a problem hiding this comment.
Yes. It only happened when FlinkOptions.METADATA_ENABLED was set to true.
Member
Author
|
@hudi-bot run azure |
1 similar comment
Member
Author
|
@hudi-bot run azure |
Member
Author
|
Hi @codope, ptal, thanks! |
danny0405
approved these changes
Jan 7, 2023
nsivabalan
pushed a commit
to nsivabalan/hudi
that referenced
this pull request
Mar 22, 2023
fengjian428
pushed a commit
to fengjian428/hudi
that referenced
this pull request
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Properly set engine type when creating
MetadataWriteConfigfromHoodieWriteConfig.Impact
Won't get warning
Embedded timeline server is disabled, fallback to use direct marker type for sparkRisk level (write none, low medium or high below)
none
Documentation Update
none
Contributor's checklist